Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove subs type optimization causing find method issues #6532

Merged
merged 3 commits into from
Sep 12, 2024
Merged

Remove subs type optimization causing find method issues #6532

merged 3 commits into from
Sep 12, 2024

Conversation

xunilrj
Copy link
Contributor

@xunilrj xunilrj commented Sep 11, 2024 •
edited
Loading

Description

This PR fixes #6491

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@xunilrj xunilrj requested a review from a team as a code owner September 11, 2024 12:09
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Sep 11, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #6532 will not alter performance

Comparing xunilrj/fix-subs-type (ee5c7bc) with master (11d8f54)

Summary

✅ 22 untouched benchmarks

@xunilrj xunilrj self-assigned this Sep 11, 2024
@IGI-111
Copy link
Contributor

IGI-111 commented Sep 11, 2024

So what ends up being the performance impact here? Is there any at all?

@xunilrj
Copy link
Contributor Author

xunilrj commented Sep 11, 2024 •
edited
Loading

So what ends up being the performance impact here? Is there any at all?

The last two commits are from this PR. I'm not sure what happened with that outlier, can be ignored.

image

2.36433582284 1725842443-conditional constant propagation
2.45822637305 1726056540-remove subs type optimization causing find method issues	
2.44941160090 1726057881-more tests

In this project that I tested the difference is 0.09s (3%).

So it seems interesting to try to introduce the optimization again later.

IGI-111
IGI-111 approved these changes Sep 11, 2024
View reviewed changes
Copy link
Contributor

@IGI-111 IGI-111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there's no major setback then let's merge this.

@IGI-111 IGI-111 requested a review from a team September 11, 2024 15:58
@IGI-111 IGI-111 merged commit fa3dafa into master Sep 12, 2024
40 checks passed
@IGI-111 IGI-111 deleted the xunilrj/fix-subs-type branch September 12, 2024 03:52
@xunilrj xunilrj mentioned this pull request Sep 16, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdankel sdankel sdankel approved these changes

@IGI-111 IGI-111 IGI-111 approved these changes

@tritao tritao tritao approved these changes

Assignees

@xunilrj xunilrj

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Trait inference regression in 0.63.2+
5 participants
@xunilrj @IGI-111 @tritao @sdankel @JoshuaBatty